Thanks for working on this. I have 1 or 2 nits/questions, please see below. On Wed, Mar 25, 2020 at 01:45:10PM +0000, András Kucsma via GitGitGadget wrote: > From: Andras Kucsma <r0maikx02b@xxxxxxxxx> > > On Windows with git installed through cygwin, GIT_ASKPASS failed to run My understanding is, that git under cygwin needs this patch (so to say), but isn't it so, that even Git for Windows has the same issue ? The headline of the patch and the indicate so. How about the following ? On Windows GIT_ASKPASS failed to run for relative and absolute paths containing only backslashes as directory separators. The reason was that Git assumed that if there are no forward slashes in the executable path, it has to search for the executable on the PATH. The fix is to look for OS specific directory separators, not just forward slashes, so introduce a helper function has_dir_sep() and use it in run-command.
