Hi Peff, On Tue, 24 Mar 2020, Jeff King wrote: > On Tue, Mar 24, 2020 at 10:41:58PM +0100, Johannes Schindelin wrote: > > > > The thing I was more worried about is that it's technically a behavior > > > change to set up GNUPGHOME when we're not going to use it (as well as > > > create the directory). But I find it hard to imagine a test that would > > > be affected where my suggested solution wouldn't be "fix the test". > > > > It is _half_ a change in behavior: in case that `gpg` was found, and does > > not have a known-bad version, we set up the environment variable, _even > > if_ the test-signing fails. In other words, we don't roll back the > > environment variable. > > > > As such, I figure that setting it globally _before_ even evaluating the > > prereq is okay. > > > > Therefore, it is relatively easy to turn this thing into a set of lazy > > prereqs, which is better, conceptually, I think. I am in the process of > > making it so. > > Er, isn't that what my patch did? I'm fine if you have another approach > to present, but I'm worried we might be duplicating effort. I missed that your second patch made `GPG` lazy, too. My version is slightly different from yours, though: I do not insist on setting the environment variable `GNUPGHOME` only after the `mkdir` succeeds, as the `gpg --sign` later on might fail anyway, which means that we _already_ could end up with `GNUPGHOME` set and the prereq `GPG` _not_ set. Ciao, Dscho
