Hi Jeff, On Thu, 5 Mar 2020, Jeff Hostetler wrote: > On 3/4/2020 4:35 PM, Johannes Schindelin wrote: > > > > On Mon, 2 Mar 2020, Emily Shaffer wrote: > > > > > .gitignore | 1 + > > > Documentation/git-bugreport.txt | 46 ++++++++++++++ > > > Makefile | 5 ++ > > > bugreport.c | 105 ++++++++++++++++++++++++++++++++ > > > command-list.txt | 1 + > > > strbuf.c | 4 ++ > > > strbuf.h | 1 + > > > t/t0091-bugreport.sh | 61 +++++++++++++++++++ > > > 8 files changed, 224 insertions(+) > > > create mode 100644 Documentation/git-bugreport.txt > > > create mode 100644 bugreport.c > > > create mode 100755 t/t0091-bugreport.sh > > > > Hmm. I am still _quite_ convinced that this would be much better as a > > built-in. Remember, non-built-ins come with a footprint, and I do not > > necessarily think that you will want to spend 3MB on a `git-bugreport` > > executable when you could have it for a couple dozen kilobytes inside > > `git` instead. > > > > Ciao, > > Dscho > > Having this command be a stand-alone exe rather than a builtin allows > it to have a different linkage. For example, you could include the > libcurl and other libraries that are only linked into the transports. > And then report version numbers for them if you wanted. While that is true, I would argue that this is quite likely using the _wrong_ information if the user has a different `git-remote-https` in their `PATH`. In other words, that information could _mislead_ the recipient of the bug report. Now, other people might argue that the different linkage lets `git-bugreport` maybe work where `git` would fail to load a required dynamic library. But again, I would counter that this is a false assumption: since `git-bugreport` relies on `libgit.a`, it essentially _has_ to have the same linkage as `git`, or a superset thereof. So: No, I really think this is going the wrong direction. If we want `bugreport` to be a first-class citizen, we should treat it as such. That entails making it a built-in. That entails teaching `git-remote-https` (and potentially other non-builtins) to sprout that option to enquire other information that should be included in the generated part of the bug report. Ciao, Dscho
