Junio C Hamano <gitster@xxxxxxxxx> writes:
> "Heba Waly via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>
>> +static struct {
>> + const char *key;
>> + int enabled;
>> +} advice_setting[] = {
>> + [ADVICE_ADD_EMBEDDED_REPO] = { "addEmbeddedRepo", 1 },
>
> It would be nicer to future developers to flip the polarity, as we
> do not have to write 1 all over the place, especially if we plan to
> extend the structure over time and to use designated initializers
> for only certain fields...
Just to avoid needless churn, I think this does not matter in the
longer term, so .enabled is OK as-is. The reason I say so is
because, even though renaming to .disabled to allow initializers to
default it to 0 is nicer for those who write the initializers
manually, and it especially is true when we have more fields in the
struct (we may add descriptive text so that we can issue an on-line
help, for example), but I expect that would happen much later than
we start generating these parts of the source code in two places
(the initializer for advice_setting[] and the advice_type enum) from
a single source by mechanical process. And the auto-generation will
eliminate the burden of writing 1 manually.
