Hi, On Tue, 3 Mar 2020, Bryan Turner wrote: > On Tue, Mar 3, 2020 at 12:23 AM Takuya N via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: > > > > From: Takuya Noguchi <takninnovationresearch@xxxxxxxxx> > > > > The notation <commit> can be misunderstandable only for commit SHA1, > > but merge-base accepts any commit references. Like reflog, the name of > > arguments should be <ref> instead of <commit>. > > To me, this change goes too far in the opposite direction: Now it > sounds like the command only accepts refs, when it actually accepts > any "commit-ish"--i.e., anything that can be coerced to a commit. > ("git worktree" uses this term in its usage for "add", for example.) Maybe we can go for `rev` instead of `ref`? Ciao, Dscho