On 2020-02-25 at 19:25:46, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > >> /* parse signature first; we might not even have a subject line */ > >> - *sig = buf + parse_signature(buf, strlen(buf)); > >> - *siglen = strlen(*sig); > >> + parse_signature(buf, end - buf, &payload, &signature); > >> + *sig = strbuf_detach(&signature, siglen); > > > > While I like the spirit of this patch, it makes the Windows build fail. I > > put this on top of Git for Windows' `shears/pu` branch to fix it (maybe > > you could adopt a variation of it?): > > FWIW, it's of course not just Windows, but on anything whose size_t > != ulong, e.g. https://travis-ci.org/git/git/jobs/654661788 (Linux32) I will likely not get to a reroll before Thursday at the earliest due to other commitments, so if it's more convenient for you to eject this from pu and just pick up v3 when I get around to it, please feel free. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
