Re: [PATCH v2 18/24] gpg-interface: improve interface for parsing tags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

>>  	/* parse signature first; we might not even have a subject line */
>> -	*sig = buf + parse_signature(buf, strlen(buf));
>> -	*siglen = strlen(*sig);
>> +	parse_signature(buf, end - buf, &payload, &signature);
>> +	*sig = strbuf_detach(&signature, siglen);
>
> While I like the spirit of this patch, it makes the Windows build fail. I
> put this on top of Git for Windows' `shears/pu` branch to fix it (maybe
> you could adopt a variation of it?):

FWIW, it's of course not just Windows, but on anything whose size_t
!= ulong, e.g. https://travis-ci.org/git/git/jobs/654661788 (Linux32)



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux