On Sun, Feb 23, 2020 at 09:48:34AM +0100, Martin Ågren wrote: > We `cat` files, but don't inspect or grab the contents in any way. These > `cat` calls look like remnants from a debug session, so it's tempting to > get rid of them. But they do actually verify that the files exist, which > might not necessarily be the case for some failure modes of `git apply > --reject`. Let's not lose that. > > Convert the `cat` calls to use `test_path_is_file` instead. This is of > course still a minor change since we no longer verify that the files can > be opened for reading, but that is not something we usually worry about. This reasoning makes sense to me. Thanks for being careful in thinking about possible ramifications of removing these otherwise useless-looking cat statements. This is and the other two patches all look good to me. -Peff
