On Tue, Feb 18, 2020 at 09:28:31AM -0800, Junio C Hamano wrote: > >> I think the question reader had was "why *right*?" > > > > Ah. The answer is: because it's not SYMMETRIC_LEFT. ;) > > > > The counting code accumulates there by default when there are no side > > markings, so that's what it will report when there's no left_right or > > cherry_mark (which we know will be the case here, since we die() > > otherwise). > > Yup. > > /* > * The object count is always accumulated in the .count_right > * field for traversal that is not a left-right traversal, > * and cmd_rev_list() made sure that a .count request that > * wants to count non-commit objects, which is handled by > * the show_object() callback, does not ask for .left_right. > */ > > Overkill? I dunno. No, I think it looks good. Want to squash that in (and I'll do likewise locally)? -Peff
