On Wed, 5 Feb 2020 at 21:06, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Martin Ågren <martin.agren@xxxxxxxxx> writes:
>
> > On Fri, 24 Jan 2020 at 04:41, <emilyshaffer@xxxxxxxxxx> wrote:
> >> + char *shell = NULL;
> >
> > (Unnecessary initialization.)
> >
> >> + shell = getenv("SHELL");
> >> + strbuf_addf(sys_info, "$SHELL (typically, interactive shell): %s\n",
> >> + shell ? shell : "(NULL)");
> >
> > Thanks for avoiding a classic pitfall. :-)
> >
> > "<unused>" instead of "(NULL)"? "NULL" is mostly an implementation
> > detail.
>
> Isn't that <unset>?
Heh, yes, "SHELL: unused" sounds wrong. :-)
Martin
