Re: [PATCH v5 08/15] bugreport: include user interactive shell

[Martin Ågren <martin.agren@xxxxxxxxx>]

On Fri, 24 Jan 2020 at 04:41, <emilyshaffer@xxxxxxxxxx> wrote:
> +       char *shell = NULL;

(Unnecessary initialization.)

> +       shell = getenv("SHELL");
> +       strbuf_addf(sys_info, "$SHELL (typically, interactive shell): %s\n",
> +                   shell ? shell : "(NULL)");

Thanks for avoiding a classic pitfall. :-)

"<unused>" instead of "(NULL)"? "NULL" is mostly an implementation
detail.


Martin