On Thu, Jan 30, 2020 at 11:28:40PM +0100, Martin Ågren wrote:
> On Fri, 24 Jan 2020 at 04:41, <emilyshaffer@xxxxxxxxxx> wrote:
> > + char *shell = NULL;
>
> (Unnecessary initialization.)
>
> > + shell = getenv("SHELL");
> > + strbuf_addf(sys_info, "$SHELL (typically, interactive shell): %s\n",
> > + shell ? shell : "(NULL)");
>
> Thanks for avoiding a classic pitfall. :-)
Thank Junio. I fell right into it because it Just Works in gcc. ;)
> "<unused>" instead of "(NULL)"? "NULL" is mostly an implementation
> detail.
Sure, why not.
