Hi, Actually I prefer to keep the parentheses, it makes better sense to me. It feels correct with them when I speak it loudly, incorrect without. BR, Jacques -- Monsieur Biz @jacquesbh +33 (0)6 75 54 11 97 GPG : https://keybase.io/jacquesbh Le mer. 5 févr. 2020 à 19:49, Junio C Hamano <gitster@xxxxxxxxx> a écrit : > > Jacques Bodin-Hullin <j.bodinhullin@xxxxxxxxxxxxxxx> writes: > > > Signed-off-by: Jacques Bodin-Hullin <j.bodinhullin@xxxxxxxxxxxxxxx> > > --- > > parse-options.c | 4 ++-- > > t/t0040-parse-options.sh | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/parse-options.c b/parse-options.c > > index b42f54d48b96c..71dbe84d896b4 100644 > > --- a/parse-options.c > > +++ b/parse-options.c > > @@ -420,7 +420,7 @@ static void check_typos(const char *arg, const struct option *options) > > return; > > > > if (starts_with(arg, "no-")) { > > - error(_("did you mean `--%s` (with two dashes ?)"), arg); > > + error(_("did you mean `--%s` (with two dashes)?"), arg); > > Makes sense. Not just there is an extra SP before the question > mark, the question mark is about the whole sentence, so pushing > it out of the parentheses also is a good change. > > We might even want to lose the parentheses altogether, i.e. > > did you mean `--%s` with two dashes? > > Hmm? > > Thanks.
