Hi brian, On Sun, 26 Jan 2020, brian m. carlson wrote: > On 2020-01-26 at 10:25:31, Johannes Schindelin wrote: > > Hi brian, > > > > On Sat, 25 Jan 2020, brian m. carlson wrote: > > > > > This is the second-to-last series of test fixes for SHA-256. > > > > > > As mentioned previously, the patch for t3305 seems to indicate a bug in > > > the notes code and I'm not familiar enough with that code to apply a > > > fix. This is a band-aid to get it working with SHA-256, but any > > > comments on a more robust approach would of course be welcome. > > > > > > Changes from v1: > > > * Drop patch for t3404 in favor of Dscho's fix. > > > * Drop patch for t5616 in favor of Jonathan Tan's fix. > > > * Add missing sign-off. > > > * Move test_oid_init into the correct patch. > > > > Would you terribly mind pushing up your local branch to a public place? I > > used the apply-from-public-inbox.sh script I maintain at > > https://github.com/git-for-windows/build-extra to apply your patch series > > on top of v2.25.0, but I got this: > > > > Applying: t5607: make hash size independent > > Using index info to reconstruct a base tree... > > M t/t5607-clone-bundle.sh > > Falling back to patching base and 3-way merge... > > No changes -- Patch already applied. > > > > (I want to have a look at the notes fanout. Will keep you posted on my > > investigation there.) > > The branch is test-fixes-part8 on https://github.com/bk2204/git.git. > It's currently based off master. Thank you! Dscho
