On Wed, Dec 11, 2019 at 1:46 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Luke Diamand <luke@xxxxxxxxxxx> writes: > > > On Wed, 11 Dec 2019 at 17:57, Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> > >> Denton Liu <liu.denton@xxxxxxxxx> writes: > >> > >> > On Wed, Dec 11, 2019 at 08:54:49AM -0800, Junio C Hamano wrote: > >> > From what I can tell, Ben agreed to have this series superseded by Yang > >> > Zhao's competing series[1]. > >> > >> OK. Let me not worry about this one, then, at least not yet. > >> > > > > Oh, I hadn't seen Yang's python3 changes! ... > > What do we need to do to get these ready for merging? > > Somebody needs to take the ownership of the topic---we cannot afford > to have two independently made topics competing reviewers' attention. > > If Ben wants to drop his version and instead wants to use Yang's > ones, that's OK but Ben probably is in a lot better position than > bystanders like me to review and comment on Yang's to suggest > improvements, if he hasn't done so. The same for those who reviewed > Ben's series earlier. > > It would make sure that the single topic a combined effort to > produce the best of both topics. If there is something Ben's > patches did that is lacking in Yang's, it may be worth rebuilding it > on top of Yang's series. Sorry about the bit of communication mess there. I should have paid more attention to who were chiming in to Ben's series and added CCs appropriately. The timing was definitely a bit awkward as we were both only dedicating part of work-time to the patchsets. The outcome of discussion between Ben and I were that it made the most sense to use my set as the base to rebuild his quality-of-life changes. My patchset (plus one missing change I've not sent out yet) will pass all existing tests. I will take ownership of this merge, probably as a separate patchset. -- Yang
