Luke Diamand <luke@xxxxxxxxxxx> writes: > On Wed, 11 Dec 2019 at 17:57, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> >> Denton Liu <liu.denton@xxxxxxxxx> writes: >> >> > On Wed, Dec 11, 2019 at 08:54:49AM -0800, Junio C Hamano wrote: >> >> Ben Keene <seraphire@xxxxxxxxx> writes: >> >> >> >> > Yes indeed! >> >> > >> >> > I hadn't pulled before I attempted the rebase, and got bit. Yes those >> >> > shouldn't be there! >> >> >> >> So, other than that, this is ready to be at least queued on 'pu' if >> >> not 'next' at this point? >> > >> > From what I can tell, Ben agreed to have this series superseded by Yang >> > Zhao's competing series[1]. >> >> OK. Let me not worry about this one, then, at least not yet. >> > > Oh, I hadn't seen Yang's python3 changes! I haven't been paying attention to them either. The patches I started commenting on from Ben were easy to read and understand, and I didn't even know until Denton pointed out that Ben's series yielded the way. > What do we need to do to get these ready for merging? Somebody needs to take the ownership of the topic---we cannot afford to have two independently made topics competing reviewers' attention. If Ben wants to drop his version and instead wants to use Yang's ones, that's OK but Ben probably is in a lot better position than bystanders like me to review and comment on Yang's to suggest improvements, if he hasn't done so. The same for those who reviewed Ben's series earlier. It would make sure that the single topic a combined effort to produce the best of both topics. If there is something Ben's patches did that is lacking in Yang's, it may be worth rebuilding it on top of Yang's series.
