On Wed, 27 Nov 2019 at 11:24, Jeff King <peff@xxxxxxxx> wrote: > > > Extend test-lib.sh to add a FREEBSD prereq (akin to MINGW) and add !FREEBSD > > to these tests. > > Before we start growing more system-specific prereqs here, can we add a > layer of indirection? Convert this test to use a REGEX_ALLOW_ILLSEQ > prereq (or maybe there's a better name), and then set it for both mingw > and freebsd? Thanks, and that makes sense, but should we make the sense the opposite way - set REGEX_ALLOW_ILLSEQ only for glibc (including Cygwin, I guess)? This also applies only to two cases ("latin1 + locale" and "latin1 + locale + invalid needle"). There are other !MINGW tests in t4210-log-i18n.sh which do not use invalid UTF-8 and work fine on FreeBSD.