On Wed, Nov 27, 2019 at 03:17:08PM +0000, Ed Maste wrote: > From: Ed Maste <emaste@xxxxxxxxxxx> > > A number of t4210-log-i18n tests added in 4e2443b181 set LC_ALL to a UTF-8 > locale (is_IS.UTF-8) but then pass an invalid UTF-8 string to --grep. > FreeBSD's regcomp() fails in this case with REG_ILLSEQ sequence which git > then passes to die(): > > fatal: command line: '�': illegal byte sequence > > When these tests were added the commit message stated: > > | It's possible that this > | test breaks the "basic" and "extended" backends on some systems that > | are more anal than glibc about the encoding of locale issues with > | POSIX functions that I can remember > > which seems to be the case here. Makes sense, but... > Extend test-lib.sh to add a FREEBSD prereq (akin to MINGW) and add !FREEBSD > to these tests. Before we start growing more system-specific prereqs here, can we add a layer of indirection? Convert this test to use a REGEX_ALLOW_ILLSEQ prereq (or maybe there's a better name), and then set it for both mingw and freebsd? -Peff
