Re: [PATCH v2 6/6] commit: support the --pathspec-from-file option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19.11.2019 7:10, Junio C Hamano wrote:
+--pathspec-file-nul::
+	Only meaningful with `--pathspec-from-file`. Pathspec elements are
+	separated with NUL character and are not expected to be quoted.

Although it is not incorrect, "are not expected to be quoted" feels
a bit weak as the technical description.  Are they not expected to
be quoted, but the command gracefully works on them even when they
are found to be quoted?

Rephrasing to avoid such misinterpretation may be worth doing,
perhaps

	... and are taken as-is without unquoting (i.e. as if
	`core.quotePath` is set to `false`).

or something like that?

I think that a reference to `core.quotePath` could be confusing here, because it doesn't really affect the option. I have reworded it in V3, please see if you like it.

Thanks for pointing out!



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux