Re: [PATCH v2 6/6] commit: support the --pathspec-from-file option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Alexandr Miloslavskiy via GitGitGadget" <gitgitgadget@xxxxxxxxx>
writes:

> @@ -277,6 +278,18 @@ FROM UPSTREAM REBASE" section in linkgit:git-rebase[1].)
>  	the last commit without committing changes that have
>  	already been staged. If used together with `--allow-empty`
>  	paths are also not required, and an empty commit will be created.
> +	
> +--pathspec-from-file=<file>::
> +	Pathspec is passed in `<file>` instead of commandline args. If
> +	`<file>` is exactly `-` then standard input is used. Pathspec
> +	elements are separated by LF or CR/LF. Pathspec elements can be
> +	quoted as explained for the configuration variable `core.quotePath`
> +	(see linkgit:git-config[1]). See also `--pathspec-file-nul` and
> +	global `--literal-pathspecs`.

OK.

> +--pathspec-file-nul::
> +	Only meaningful with `--pathspec-from-file`. Pathspec elements are
> +	separated with NUL character and are not expected to be quoted.

Although it is not incorrect, "are not expected to be quoted" feels
a bit weak as the technical description.  Are they not expected to
be quoted, but the command gracefully works on them even when they
are found to be quoted?

Rephrasing to avoid such misinterpretation may be worth doing,
perhaps

	... and are taken as-is without unquoting (i.e. as if
	`core.quotePath` is set to `false`).

or something like that?

Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux