Hi,
On Mon, 23 Jul 2007, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>
> > When asking "git log -g --all", clearly you want to see only those refs
> > that do have reflogs, but you do not want it to fail, either.
> >
> > So instead of die()ing, complain about it, but move on to the other refs.
>
> Hmph, do we even want to error(), I wonder...
Maybe not. I thought it was some useful information, though.
> Can you tell, at that point, if there were explicit branch names given
> originally on the command line, or the refs came
> from --all?
No:
if (!strcmp(arg, "--all")) {
handle_all(revs, flags);
continue;
}
which calls
static void handle_all(struct rev_info *revs, unsigned flags)
{
struct all_refs_cb cb;
cb.all_revs = revs;
cb.all_flags = flags;
for_each_ref(handle_one_ref, &cb);
}
which in turn calls
static int handle_one_ref(const char *path, const unsigned char *sha1, int flag,
void *cb_data)
{
struct all_refs_cb *cb = cb_data;
struct object *object = get_reference(cb->all_revs, path, sha1,
cb->all_flags);
add_pending_object(cb->all_revs, object, path);
return 0;
}
If you do not say --all, handle_revision_arg() is called, which calls
add_pending_object thus:
add_pending_object(revs, &a->object, this);
add_pending_object(revs, &b->object, next);
or thus
add_pending_object_with_mode(revs, object, arg, mode);
So no, there is not really a chance to see how the refs were specified at
the time add_pending_object() is called.
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
