Thomas Gummerer <t.gummerer@xxxxxxxxx> writes: >> ... This may want to become >> >> git rev-parse --verify :file && >> >> or >> >> git show :file >actual && echo bar >expect && >> test_cmp expect actual && >> >> perhaps? > > Hmm I just copy-pasted this from somewhere else in this test file. > I'll add a preparatory patch getting rid of "$(git command substitution)" > as I don't believe Denton got to t3903 yet. > > There's some more opportunities for modernization of this test file, > but I refrained from doing that to not blow up this bug fix series too > much. It is very much appreciated that you aimed to keep the topic focused on the fixing. What I meant was merely to avoid making things worse by adding more of $(git command substitution), not cleaning up the existing ones. Thanks.