Denton Liu <liu.denton@xxxxxxxxx> writes: > On Tue, Nov 12, 2019 at 01:46:33PM +0900, Junio C Hamano wrote: >> Denton Liu <liu.denton@xxxxxxxxx> writes: >> >> > Before, when there was a space, we'd start a new word and, as a result, >> > fallback to __git_complete_refs() and `--onto` would be completed this >> > way. However, now we match the `--*` case which does not know how to >> > offer completions for refs. >> >> Very well explained. Thanks, will queue. > > Could you please queue this on the tip of > 'dl/complete-rebase-and-archive' since it fixes a regression introduced > in that branch? The topic dl/complete-rebase-onto, which has this patch, is built directly on top of that topic. Since we may need to rewrite the patch when further review comments come in, I'd prefer to leave it separate from the other topic (which must not be rewritten) at least for now. Thanks.