Re: [PATCH v4 3/8] t3900: demonstrate git-rebase problem with multi encoding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-11-07 03:02:18 -0500, Jeff King wrote:
> >                 git config i18n.commitencoding ISO-2022-JP &&
> >                 echo ISO-2022-JP >>F &&
> >                 git commit -a -F "$TEST_DIRECTORY/t3900/ISO-2022-JP.txt" &&
> 
> ...you still can't just run this manually because of other lines like
> this one.

Except we can with a little effort:

    export TEST_DIRECTORY=..

> It's also weirdly unlike all of the other tests, which creates confusion
> for people reading the code. IMHO the tradeoff isn't worth it.

Hm, I think it's the test_commit_autosquash_flag is the one that is weird
in this file. Most of other sets of tests (line 89-176) use the same quote.

test_commit_autosquash_flag is the inconsistent one,
for the most part, it doesn't employ the funny quote,
but it uses the funny one in the `git cat-file` line.

-- 
Danh



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux