On Tue, Oct 22, 2019 at 7:46 PM Jonathan Tan <jonathantanmy@xxxxxxxxxx> wrote: > > > From: Jeff King <peff@xxxxxxxx> > > > > In a following commit we will need to allocate a variable > > number of bitmap words, instead of always 32, so let's add > > bitmap_word_alloc() for this purpose. > > > > We will also always access at least one word for each bitmap, > > so we want to make sure that at least one is always > > allocated. > > The last paragraph is not true - we still can allocate 0. (We just ensure > that when we grow, we grow to at least 1.) I think we should just > delete the last paragraph - the first paragraph is sufficient. Ok, I removed the last paragraph in my current version. > Other than that, all patches up to but not including the last one look > good, except the ones that just add a new function because I'll have to > review the last patch to see how they are used. Thanks for your review, Christian.
