Hi Rohit
On 06/10/2019 18:57, Rohit Ashiwal wrote:
On Fri, 27 Sep 2019 11:00:58 +0100 Phillip Wood <phillip.wood123@xxxxxxxxx> wrote:
[...]
Thanks for all the advice and improvements.
[...]
It's good to see the new test. Did you see Stolee's email [4] about the
test coverage of the previous version of this series? You should check
that this series tests all the untested non-error handling lines.
[4]
https://public-inbox.org/git/1ed86989-9ba2-0cd7-b6f7-654d1943b1d7@xxxxxxxxx/
Yes, I've seen it and have improved the test since.
Have you improved it since v4? Stolee's latest email [1] still shows
push_date() as completely untested. We need a test that gets the
sequencer to fork git-commit, the easiest way is probably to reword a
commit. Also the new code for ignoring the date when we fork 'git merge'
is untested. Having a test that does an octopus merge or sets a merge
strategy (or merge strategy option) should fix that.
Best Wishes
Phillip
[1]
https://public-inbox.org/git/ed8e65a2-72e8-210c-d4a4-eacdb5c7b0e8@xxxxxxxxx/
Thanks
Rohit
