On Fri, 27 Sep 2019 11:00:58 +0100 Phillip Wood <phillip.wood123@xxxxxxxxx> wrote: > > [...] Thanks for all the advice and improvements. > [...] > It's good to see the new test. Did you see Stolee's email [4] about the > test coverage of the previous version of this series? You should check > that this series tests all the untested non-error handling lines. > > [4] > https://public-inbox.org/git/1ed86989-9ba2-0cd7-b6f7-654d1943b1d7@xxxxxxxxx/ Yes, I've seen it and have improved the test since. Thanks Rohit