Re: [PATCH] Avoid to duplicate commit message when is not encoded

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/22/07, Junio C Hamano <gitster@xxxxxxxxx> wrote:
Alex Riesen <raa.lkml@xxxxxxxxx> writes:

> Marco Costalba, Sun, Jul 22, 2007 10:23:05 +0200:
>> +            if (encoding) // we'll strip encoding header later
>
> You better avoid using C++ comments, not all C compilers support them.

I've "fixed" them.


Sorry, I wrote them automatically without thinking it is better to
avoid them in C. BTW I would think it's more about coding style then
compiler support.

>> +            else
>> +                    return NULL; // nothing to do
>
> And you better avoid such useless comments too

I think this one is probably a good-to-have.  It really needs a
bit of thinking why there is nothing to do in this case.  At
least for me it did ;-)


Me too ;-)
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux