When a commit message doesn't have encoding information and encoding output is utf-8 (default) then an useless xstrdup() of commit message is done. If we assume most of users live in an utf-8 world, this useless copy is the common case. Performance issue found with KCachegrind. Signed-off-by: Marco Costalba <mcostalba@xxxxxxxxx> --- commit.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/commit.c b/commit.c index 4c5dfa9..ba8413b 100644 --- a/commit.c +++ b/commit.c @@ -721,7 +721,10 @@ static char *logmsg_reencode(const encoding = get_header(commit, "encoding"); use_encoding = encoding ? encoding : utf8; if (!strcmp(use_encoding, output_encoding)) - out = xstrdup(commit->buffer); + if (encoding) // we'll strip encoding header later + out = xstrdup(commit->buffer); + else + return NULL; // nothing to do else out = reencode_string(commit->buffer, output_encoding, use_encoding); -- 1.5.3.rc2.23.g4c77-dirty - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
