Re: [PATCH 0/3] fixes related to `make hdr-check`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Denton,

On Mon, 23 Sep 2019, Denton Liu wrote:

> This patchset relates to `make hdr-check`. The first patch addresses
> getting it to run on platforms which require custom CFLAGS.
>
> The other two patches address errors/warnings caught by actually running
> `make hdr-check`.
>
>
> Denton Liu (3):
>   Makefile: use $(ALL_CFLAGS) in $(HCO) target
>   apply.h: include missing header
>   promisor-remote.h: include missing header

These all make sense to me (including 4/3). I wonder whether we would
want a 5/3 that essentially does this:

-- snipsnap --
diff --git a/ci/run-static-analysis.sh b/ci/run-static-analysis.sh
index a19aa7ebbc0..65bcebda41a 100755
--- a/ci/run-static-analysis.sh
+++ b/ci/run-static-analysis.sh
@@ -26,4 +26,7 @@ then
 	exit 1
 fi

+make hdr-check ||
+exit 1
+
 save_good_tree




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux