Hi Denton, On Mon, 23 Sep 2019, Denton Liu wrote: > On platforms that can run `make hdr-check` but require custom flags, > this target was failing because none of them were being passed to the > compiler. For example, on MacOS, the NO_OPENSSL flag was being set but > it was not being passed into compiler so the check was failing. > > Pass $(ALL_CFLAGS) into the compiler for the $(HCO) target so that these > custom flags can be used. > > Signed-off-by: Denton Liu <liu.denton@xxxxxxxxx> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index f879697ea3..d8df4e316b 100644 > --- a/Makefile > +++ b/Makefile > @@ -2773,7 +2773,7 @@ CHK_HDRS = $(filter-out $(EXCEPT_HDRS),$(patsubst ./%,%,$(LIB_H))) > HCO = $(patsubst %.h,%.hco,$(CHK_HDRS)) > > $(HCO): %.hco: %.h FORCE > - $(QUIET_HDR)$(CC) -include git-compat-util.h -I. -o /dev/null -c -xc $< > + $(QUIET_HDR)$(CC) -include git-compat-util.h -I. -o /dev/null -c -xc $(ALL_CFLAGS) $< Isn't this essentially identical to what I sent in https://public-inbox.org/git/pull.129.git.gitgitgadget@xxxxxxxxx/ ? Ciao, Dscho > > .PHONY: hdr-check $(HCO) > hdr-check: $(HCO) > -- > 2.23.0.565.g1cc52d20df > >
