Hi Gábor, On Mon, 26 Aug 2019, SZEDER Gábor wrote: > On Sun, Aug 25, 2019 at 11:21:23PM +0100, Philip Oakley wrote: > > >>>>diff --git a/.gitignore b/.gitignore > > >>>>index e096e0a51c..e7bb15d301 100644 > > >>>>--- a/.gitignore > > >>>>+++ b/.gitignore > > >>>>@@ -230,6 +230,7 @@ > > >>>> *.ipdb > > >>>> *.dll > > >>>> .vs/ > > >>>>-/Debug/ > > >>>>-/Release/ > > >>>>+*.manifest > > >>>This new line ignores the tracked file 'compat/win32/git.manifest' > > >>>that was added fairly recently in fe90397604 (mingw: embed a manifest > > >>>to trick UAC into Doing The Right Thing, 2019-06-27). > > >>> > > >>>I wonder whether that's intentional or accidental. > > >>> > > >>>I'm inclined to think that it's merely accidental, because, as far as > > >>>I understand, this is an old-ish patch from times when there wasn't > > >>>any 'git.manifest' file in tree, and simply noone noticed that in the > > >>>meantime we got one. But I have no idea about how a Git build with > > >>>Visual Studio is supposed to work, so it doesn't really matter what > > >>>I'm inclined to think :) > > >>> > > >>At the time, it was just one of the many non-source files that were > > >>generated by Visual Studio that cluttered the status list and also could > > >>accidentally added to the tracked files. > > >> > > >>The newly added .manifest file does appear to be there to 'trick' the > > >>Windows User Access Control (UAC) which otherwise can be an annoyance to > > >>'regular' users. > > >Sorry, I'm not sure how to interpret your reply, and can't decide > > >whether it tries to justify why that tracked file should be ignored, > > >or explains that ignoring it was accidental. > > > > > >Anyway, ignoring that tracked file apparently triggered a nested > > >worktree-related bug in 'git clean', which can lead to data loss: > > > > > >https://public-inbox.org/git/20190825185918.3909-1-szeder.dev@xxxxxxxxx/ > > > > > Basically manifests are a build artefact from Visual Studio [1], so it was > > just another file to be ignored, from a _source_ control control viewpoint. > > I understand that manifest files, in general, are build artifacts. > But does Visual Studio overwrite the existing > 'compat/win32/git.manifest' file in particular? Yes or no? :) No. The reason this entry was there: at least _some_ Visual Studio versions (IIRC), auto-generates `.manifest` files when the project does not have any. But now we do. So this line's gotta go. #leftoverbits ? Ciao, Dscho
