> On Aug 26, 2019, at 11:33 AM, Jeff King <peff@xxxxxxxx> wrote: > > On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote: > >> "Andrey Portnoy via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: >> >>> Previously sprintf was the argument to the BANNED macro, where vsprintf is >>> expected. >> >> Good eyes. Thanks. > > There's an identical patch in: > > https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@xxxxxxxxxxxx/ > > and both were inspired by: > > https://news.ycombinator.com/item?id=20793298 Nope, mine was not “inspired by” that comment, noticed the bug myself. I did look at this header because it was posted on HN, though. > > whose author has little info there, but I think is separate from either > submitter. > > I don't know if we want to try to spread credit around via trailers. > "Racily-implemented-by:" ? :) > > Anyway, the original bug is mine and the patch is obviously correct. > > -Peff >