Hey, The sq_quote_buf_pretty() function does not emit anything when the incoming string is empty, but the function is to accumulate command line arguments, properly quoted as necessary, and the right way to add an argument that is an empty string is to show it quoted, i.e. ''. Looking forward to your review. Cheers! Garima Singh Reported by: Junio Hamano gitster@xxxxxxxxx [gitster@xxxxxxxxx] in https://public-inbox.org/git/pull.298.git.gitgitgadget@xxxxxxxxx/T/#m9e33936067ec2066f675aa63133a2486efd415fd Garima Singh (1): quote: handle null and empty strings in sq_quote_buf_pretty() quote.c | 12 ++++++++++++ t/t0014-alias.sh | 8 ++++++++ 2 files changed, 20 insertions(+) base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-314%2Fgarimasi514%2FcoreGit-fixQuote-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-314/garimasi514/coreGit-fixQuote-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/314 Range-diff vs v1: 1: 9d2685bdb2 < -: ---------- quote: handle null and empty strings in sq_quote_buf_pretty() -: ---------- > 1: b9a68598d7 quote: handle null and empty strings in sq_quote_buf_pretty() -- gitgitgadget
