On Mon, Aug 26, 2019 at 7:29 AM Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > On Sat, 24 Aug 2019, Carlo Arenas wrote: > > > On Mon, Aug 19, 2019 at 3:23 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > > > > There may be others I am missing. > > > > should we still support PCRE1? > > While Git for Windows has no problem to just drop PCRE1 support, FWIW I don't want to drop PCRE1 support, I was not advocating for it, but in the contrary trying to find a way to keep it working as best as possible until we really can't. > I would > like to take a longer road in Git. Like, deprecate it first (I don't > know how to do that effectively, though, as packagers usually ignore > compile warnings, maybe we need to add a Makefile knob > YES_I_WANT_TO_BUILD_WITH_PCRE1_INSTEAD_OF_PCRE2 and > YES_I_WILL_STATE_MY_REASONS_ON_THE_GIT_MAILING_LIST or something like > that). FWIW e6c531b808 (Makefile: make USE_LIBPCRE=YesPlease mean v2, not v1, 2018-03-11) put a "deprecattion" warning in the Makefile by Ævar, but last time this was discussed[1] Junio made an IMHO sound argument for why that should be removed instead but ab/pcre-jit-fixes and UTF-8 validation are likely to make that more difficult (even if it is a mostly self inflicted wound AFAIK) Carlo [1] https://public-inbox.org/git/xmqqlg4xkh28.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/
