Re: [PATCH v2] t0021: make sure clean filter runs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 22, 2019 at 08:22:40PM +0100, Thomas Gummerer wrote:
> v2 adds the comment as suggested by Szeder.

> +		# Make sure that the file appears dirty, so checkout below has to
> +		# run the configured filter.

Yeah, but that comment only really applied when setting both
timestamps.  With a simple 'touch' it's more like

  # Make sure that the file appears dirty or is at least racily clean,
  # so ...

So the next reader will know that right away, that the author didn't
overlook racyness issue.

> +		touch test.r &&
>  		filter_git checkout --quiet --no-progress empty-branch &&
>  		cat >expected.log <<-EOF &&
>  			START
> -- 
> 2.23.0.rc2.194.ge5444969c9
> 



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux