Re: [PATCH v3 5/7] quote: add sq_append_quote_argv_pretty()

[Jeff Hostetler <git@xxxxxxxxxxxxxxxxx>]

On 8/9/2019 1:54 PM, Junio C Hamano wrote:
> "Jeff Hostetler via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>
> > +/*
> > + * Legacy function to append each argv value, quoted as necessasry,
> > + * with whitespace before each value.  This results in a leading
> > + * space in the result.
> > + */
> >   void sq_quote_argv_pretty(struct strbuf *dst, const char **argv)
> > +{
> > +	if (argv[0])
> > +		strbuf_addch(dst, ' ');
> > +	sq_append_quote_argv_pretty(dst, argv);
>
> Micronit (not worth a reroll): if !argv[0], there is no need to call
> append, either.

good catch.  thanks!