V2 of this patch series cleans up some whitespace and column alignment issues in the trace2 perf and normal formats. It also removes some dead code. Jeff Hostetler (7): trace2: cleanup column alignment in perf target format trace2: trim whitespace in region messages in perf target format trace2: remove dead code in maybe_add_string_va() trace2: trim trailing whitespace in normal format error message quote: add sq_quote_argv_pretty_ltrim trace2: cleanup whitespace in normal format trace2: cleanup whitespace in perf format quote.c | 11 +++++ quote.h | 1 + t/t0211-trace2-perf.sh | 4 +- trace2/tr2_tgt_event.c | 5 --- trace2/tr2_tgt_normal.c | 33 +++++++-------- trace2/tr2_tgt_perf.c | 89 +++++++++++++++++++++++++++-------------- 6 files changed, 90 insertions(+), 53 deletions(-) base-commit: 026dd738a6e5f1e42ef0f390feacb5ed6acc4ee8 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-298%2Fjeffhostetler%2Fupstream-2230-cleanup-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-298/jeffhostetler/upstream-2230-cleanup-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/298 Range-diff vs v1: 1: 38b53da31f = 1: 38b53da31f trace2: cleanup column alignment in perf target format 2: 834ee95cd2 < -: ---------- trace2: trim whitespace in start message in perf target format 3: d2f7cf3908 < -: ---------- trace2: trim whitespace in region messages in perf target format -: ---------- > 2: db35099712 trace2: trim whitespace in region messages in perf target format -: ---------- > 3: 09dff12a7d trace2: remove dead code in maybe_add_string_va() -: ---------- > 4: d5b5a70c1b trace2: trim trailing whitespace in normal format error message -: ---------- > 5: 5059776248 quote: add sq_quote_argv_pretty_ltrim -: ---------- > 6: bb64bb2513 trace2: cleanup whitespace in normal format -: ---------- > 7: a6e5e7c70b trace2: cleanup whitespace in perf format -- gitgitgadget