Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > ... > I think it would be better to handle committer_date_is_author_date in > a single place in this function, not have two implementations one of > ... > git has a high level api for manipulation author/committer information > in ident.c, it would be best to use that. In any case code like this > should be using strbuf's rather than malloc > ... > Do the committer_date_is_author_date check after the end of this if. > > Best Wishes > > Phillip I've read all your review comments for this round, and they all cover good points. Thanks for a good reviewer and a mentor. After reading the patches myself, I have little to add ;-)
