Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > There's a couple of patches fixing mistakes in the JIT code I added > for PCRE in <20190722181923.21572-1-dev+git@xxxxxxxxx> and > <20190721194052.15440-1-carenas@xxxxxxxxx> > > This small series proposes to replace both of those. In both cases I > think we're better off just removing the relevant code. The commit > messages for the patches themselves make the case for that. I am not sure about the BUG() that practically never triggered so far (AFAICT, the check that guards the BUG() would trigger only if we later introduced a bug, calling the code to compile when we are not asked to do so)---wouldn't it be better to leave it in while there still are people who are touching the vicinity? The other two I am perfectly OK with. It is easy to resurrect the support for v1 (which may not even be needed for long) and resurrect the support for v2 with Carlo's fix, if it later turns out that some users may need to use a more complex pattern. Thanks. > Ævar Arnfjörð Bjarmason (3): > grep: remove overly paranoid BUG(...) code > grep: stop "using" a custom JIT stack with PCRE v2 > grep: stop using a custom JIT stack with PCRE v1 > > grep.c | 46 ++++++---------------------------------------- > grep.h | 9 --------- > 2 files changed, 6 insertions(+), 49 deletions(-)
