On Sat, Jun 15, 2019 at 12:06:58PM +0200, Christian Couder wrote: > Unlike hashmap that has t/helper/test-hashmap.c and t/t0011-hashmap.sh > oidmap has no specific test. The goal of this small patch series is to > change that and also improve oidmap a bit while at it. > > Changes compared to V3 are the following: > > - removed "hash" command in test-oidmap.c and "hash" test in > t0016-oidmap.sh as suggested by Peff, > > - added patch 4/4 which does the same as above in test-hashmap.c and > t0011-hashmap.sh as suggested by Peff. This version looks good to me. I do think that sha1hash() will eventually go away in favor of oidhash(), but we can approach that separately, and convert oidmap along with everyone else. It looks like we are close to being able to do that now. Grepping for sha1hash shows just about everybody dereferencing an oid object, except for the call in pack-objects.c. And skimming the callers there, they all appear to have an oid object, too. -Peff
