Unlike hashmap that has t/helper/test-hashmap.c and t/t0011-hashmap.sh oidmap has no specific test. The goal of this small patch series is to change that and also improve oidmap a bit while at it. Changes compared to V3 are the following: - removed "hash" command in test-oidmap.c and "hash" test in t0016-oidmap.sh as suggested by Peff, - added patch 4/4 which does the same as above in test-hashmap.c and t0011-hashmap.sh as suggested by Peff. Previous versions on the mailing list: V3: https://public-inbox.org/git/20190612232425.12149-1-chriscool@xxxxxxxxxxxxx/ V2: https://public-inbox.org/git/20190611082325.28878-1-chriscool@xxxxxxxxxxxxx/ V1: https://public-inbox.org/git/20190609044907.32477-1-chriscool@xxxxxxxxxxxxx/ This patch series on GitHub: https://github.com/chriscool/git/commits/oidmap Christian Couder (4): t/helper: add test-oidmap.c t: add t0016-oidmap.sh oidmap: use sha1hash() instead of static hash() function test-hashmap: remove 'hash' command Makefile | 1 + oidmap.c | 13 +---- t/helper/test-hashmap.c | 9 +-- t/helper/test-oidmap.c | 126 ++++++++++++++++++++++++++++++++++++++++ t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0011-hashmap.sh | 9 --- t/t0016-oidmap.sh | 84 +++++++++++++++++++++++++++ 8 files changed, 217 insertions(+), 27 deletions(-) create mode 100644 t/helper/test-oidmap.c create mode 100755 t/t0016-oidmap.sh -- 2.22.0.3.g82edbe9b01.dirty