Re: [PATCH] Add --show-size to git log to print message size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 15 Jul 2007 18:27:41 +0200
"Marco Costalba" <mcostalba@xxxxxxxxx> wrote:

> But your scheme does not fail if the patch is not \n terminated ?

I'm pretty sure there is always a preceding end-of-line marker,
before the terminating NUL; although i haven't broken down and
read the code yet.

> It can happen if the patch adds lines at the end of a file and the
> last line is not \n terminated.
> 
> In this case your scheme seems to miss the good next revision boundary.
> 

Just tested this case here with "git log --parents --pretty=raw -z -r -p"
and git prints out: "\ No newline at end of file"  followed by a newline
and then the NUL.

Sean
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux