On Sat, May 04, 2019 at 08:52:01AM +0200, Ævar Arnfjörð Bjarmason wrote: > > Note that Ævar's case was somebody running bitmaps locally and trying to > > push, which I think is generally not a good match for bitmaps (even when > > they work, they cost more to generate than what you save if you're only > > pushing once). > > Right. It was *not* caused by this "enable bitmaps by default on bare > repos" patch (which I wasn't even running with), but *is* indicative of > a pretty big edge case with enabling bitmaps that *will* happen for some > on such bare repos if we ship the patch. Yeah. To clarify my comments a bit: I do think it would be possible to hit a weird case like this while serving fetches (i.e., as far as I know there is nothing in what you saw that is inherent to pushes). But I do think for serving fetches, bitmaps are overall a big net win (based on my experiences). So I think it may come down to a tradeoff: enabling this by default would probably be a net win across the population, but that's little comfort to the unlucky somebody who may see it as a regression. I'm not sure which is more important to maintain. > As an aside this is the Nth time I notice how crappy that "Enumerating > objects" progress bar is. We do a *lot* of things there, including this > bitmap calculation. > > But just splitting it up might result in either no progress (all > individually below 2 seconds), or a lot of noise as you have 20 things > that each take 2 seconds. I wonder if someone's looked at supporting: > > Enumerating Objects (X%) => Calculating bitmaps (Y%) > > Where X% is the total progres, and %Y is the sub-progress. I eyeballed > doing this once by "chaining" the progress structs, but there's probably > a less crappy way... I don't think it needs to be split; I think we just need to update the object count while we're traversing the bitmaps. The problem is that the progress object is known to pack-objects.c. Without bitmaps, as the revision machinery walks the graph, our callbacks bump the progress meter every time we see an object. With bitmaps, all that walking happens behind the scenes, and the bitmap code delivers us the final answer. So we pause for a long time, and then suddenly it shoots forward. I think we'd want a way to tell the bitmap code to update our progress meter as it traverses (both single objects, but also taking into account when it finds a bitmap and then suddenly bumps the value by a large amount). -Peff
