On Wed, Mar 13, 2019 at 01:51:33AM +0000, Eric Wong wrote: > But I did find Ævar's forgotten gitperformance doc and thread > where the topic was brought up: > > https://public-inbox.org/git/20170403211644.26814-1-avarab@xxxxxxxxx/ One thing that thread reminded me of: we probably also want to default pack.writebitmaphashcache on. Otherwise the time saved during the object enumeration can backfire when we spend much more time trying delta compression (because we don't know the pathnames of any objects). The reason it defaults to off is for on-disk compatibility with JGit. But I have very little experience running without the hash-cache on. We added it very early on because we found performance was not great without it (I don't know if people running JGit have run into the same problem and if not, why not). > ------------8<--------- > Subject: [PATCH] repack: enable bitmaps by default on bare repos > > A typical use case for bare repos is for serving clones and > fetches to clients. Enable bitmaps by default on bare repos to > make it easier for admins to host git repos in a performant way. This looks good to me, with one minor nit: > +test_expect_success 'incremental repack does not complain' ' > + git -C bare.git repack -q 2>repack.err && > + ! test -s repack.err > +' This last line could use "test_must_be_empty". -Peff
