On Mon, Apr 29, 2019 at 05:32:50PM -0400, Johannes Schindelin wrote: > > Another is that I am not sure how your "fixed format" argument > > meshes with the "-b blocksize" parameter to affect the tar/pax > > output. The format may be fixed, but it is parameterized. If > > we ever need to grow the ability to take "-b", having the knowledge > > that our current code is limited to the fixed BLOCKSIZE in a single > > function (i.e. the caller of this function , not the callee) would > > be less error prone. > > This argument would hold a lot more water if the following lines were not > part of archive-tar.c: > > #define RECORDSIZE (512) > #define BLOCKSIZE (RECORDSIZE * 20) > > static char block[BLOCKSIZE]; > > If you can tell me how the `-b` (run-time) parameter can affect the > (compile-time) `BLOCKSIZE` constant, maybe I can start to understand your > concern. FWIW, I agree with you here. These patches are not making anything worse (and may even make them better, since we'd probably need to swap out the BLOCKSIZE constant for a run-time "blocksize" variable in fewer places). -Peff
