Hi Junio,
On Sat, 13 Apr 2019, Junio C Hamano wrote:
> Jeff King <peff@xxxxxxxx> writes:
>
> >> +/* writes out the whole block, or dies if fails */
> >> +static void write_block_or_die(const char *block) {
> >> + if (gzip) {
> >> + if (gzwrite(gzip, block, (unsigned) BLOCKSIZE) != BLOCKSIZE)
> >> + die(_("gzwrite failed"));
> >> + } else {
> >> + write_or_die(1, block, BLOCKSIZE);
> >> + }
> >> +}
>
> I agree everything you said you your two review messages.
>
> One thing you did not mention but I found disturbing was that this
> does not take size argument but hardcodes BLOCKSIZE.
That is very much on purpose, as this code really is specific to the `tar`
file format, which has a fixed, well-defined block size. It would make it
easier to introduce a bug if that was a parameter.
Ciao,
Dscho
