On Wed, Apr 24, 2019 at 04:49:54PM +0700, Duy Nguyen wrote: > Heh you beat me to it. My config-hooks branch [1] has not been updated > for half a year. I only skimmed through quickly so no useful comments, > but I went with a slightly different design, introducing > for_each_hook() instead (see run-command.[ch] in the last patch). I figured this was a common enough request that people wanted that it was worth doing. I'll take a look at your series and I may steal some code. > Back then I wasn't sure what would be the right policy for running > multiple hooks. By keeping the hook loop in one place, we could change > that policy much easier later (e.g. continue anyway in case of > failure, or stop as soon as you see a problem, or even run some > special hooks at the end even when there is an error earlier). Yeah, I think from feedback elsewhere, I'm going to roll it into a single function. The nature of callbacks in C makes it potentially messy, but I'll try to see if there's a tidy way to do it. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
