Re: [PATCH 1/1] configure.ac: Properly check for libintl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Vadim Kochan <vadim4j@xxxxxxxxx> writes:

>> I think
>> 
>> 	autoconf: #include <libintl.h> when checking for gettext()
>> 
>> is probably a better title.  
>> 
>> Together with your originally proposed log message, which we now
>> know explains why this inclusion makes a difference sufficiently to
>> be understandable by an average Git developer, the resulting commit
>> will communicate to our future developers the reason why we thought
>> this was a good change clearly.
>> 
>> Thanks.
>
> Thanks! Should I re-submit patch with title updated v2 ?

You could if you feel like it, but in a case like this, responding
with "Yeah, I agree with your suggestion" and telling me to retitle
is sufficient, if you have nothing else to change in the v2.

I've already did the retitling while queuing it, so no need to
resend.

Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux