Hi Junio, On Fri, Apr 19, 2019 at 01:56:48PM +0900, Junio C Hamano wrote: > Vadym Kochan <vadim4j@xxxxxxxxx> writes: > > >> Some libc implementations have function called gettext() that > >> can be linked via -lc without -lintl, but these are mere stubs > >> and do not do useful i18n. On these systems, if a program that > >> calls gettext() is built _with_ "#include <libintl.h>", the > >> linker calls for the real version (e.g. libintl_gettext()) and > >> that can be satisfied only by linking with -lintl. > >> > >> The current check to see if -lc provides with gettext() is > >> sufficient for libc implementations like GNU libc that actually > >> has full fledged gettext(); to detect libc with stub gettext() > >> and libintl with real gettext(), aliased via <libintl.h>, the > >> check to see if -lintl is necessary must be done with a sample > >> source that #include's the header file. > >> > >> Is that what is going on and why this patch is needed? > >> > > Yes you are correct. 'gettext' even might be defined as libintl_gettext. > > With this exchange, I was aiming for extracting a more useful title > for this patch out of you ;-), and I think I accomplished my goal. > > "Properly" is fairly a useless adverb in the context of a patch > title, as it does not tell us why we thought the way in which the > updated code works is more "proper". In addition, because no code > is perfect, future developers are bound to find something inproperly > done in checking for libintl after this patch gets applied. It is > better to say the most important thing the change does concisely and > concretely. > > I think > > autoconf: #include <libintl.h> when checking for gettext() > > is probably a better title. > > Together with your originally proposed log message, which we now > know explains why this inclusion makes a difference sufficiently to > be understandable by an average Git developer, the resulting commit > will communicate to our future developers the reason why we thought > this was a good change clearly. > > Thanks. Thanks! Should I re-submit patch with title updated v2 ? Regards, Vadim Kochan
